♻️ Favor Hyrax.query_service over method chaining #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we relied on the access_control object to "self
convert" via the `#valkyrie_resource` method. However, that method
circumvents the `Hyrax.query_service` which provides a more up to date
version of the permissions.
This is subtle bug is most notable when we have composite adapters;
those modeled in the `double_combo` branch.
How it manifests is as follows:
- I have a Work and ACL in Fedora.
- I update the ACL to Postgres.
- When I fetch the Work, it's in Fedora and grabs the ACL from Fedora
which is not the most current.
This relates to:
- 0de7df6
- #6670
jeremyf
force-pushed
the
adding-query_service-lookup-for-transformer
branch
from
7bbde49
to
f0e99c5
Compare
dlpierce
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is part of the looming Double Combo work for the lazy migration for Hyrax, but I figure having this reviewed separately eases the review of a chunky PR.
See Access Control List (ACL) Considerations in the Hyku wiki.
Prior to this commit we relied on the access_control object to "self convert" via the
#valkyrie_resourcemethod. However, that method circumvents theHyrax.query_servicewhich provides a more up to date version of the permissions.This is subtle bug is most notable when we have composite adapters; those modeled in the
double_combobranch.How it manifests is as follows:
This relates to:
@samvera/hyrax-code-reviewers