Empty maps have undecided separators

Closes #737
sass · Jul 3, 2019 · 9895eef · 9895eef
1 parent 821b5e2
commit 9895eef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,11 @@
   inserts at the end of the string if the `$index` is `-1`. This matches the
   behavior in LibSass and originally in Ruby Sass.
 
+* **Potentially breaking bug fix**: An empty map returned by `map-remove()` is
+  now treated as identical to the literal value `()`, rather than being treated
+  as though it had a comma separator. This matches the original behavior in Ruby
+  Sass.
+
 * The `adjust-color()` function no longer throws an error when a large `$alpha`
   value is combined with HSL adjustments.
 

diff --git a/lib/src/value/map.dart b/lib/src/value/map.dart
@@ -10,7 +10,8 @@ import 'external/value.dart' as ext;
 class SassMap extends Value implements ext.SassMap {
   final Map<Value, Value> contents;
 
-  ListSeparator get separator => ListSeparator.comma;
+  ListSeparator get separator =>
+      contents.isEmpty ? ListSeparator.undecided : ListSeparator.comma;
 
   List<Value> get asList {
     var result = <Value>[];