Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An empty map shouldn't force a comma separator in join() #737

Closed
nex3 opened this issue Jun 26, 2019 · 1 comment
Closed

An empty map shouldn't force a comma separator in join() #737

nex3 opened this issue Jun 26, 2019 · 1 comment
Labels

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 26, 2019

In Dart Sass, join(map-remove((c: d), c), 1 2 3) returns 1, 2, 3. This is incorrect—it should return 1 2 3, because an empty map should behave the same as an empty list and an empty list has no separator associated with it.

@nex3 nex3 added the bug label Jun 26, 2019
@nex3
Copy link
Contributor Author

nex3 commented Jun 26, 2019

This is part of a larger issue where empty maps are always treated as having a comma separator. They should have an undecided separator, like the value () (to which they should be identical).

nex3 added a commit to sass/sass-spec that referenced this issue Jul 3, 2019
nex3 added a commit that referenced this issue Jul 3, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Jul 3, 2019
nex3 added a commit that referenced this issue Jul 3, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Jul 3, 2019
@nex3 nex3 closed this as completed in 47e0cfc Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant