Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge feature.use into master #724

Merged
merged 22 commits into from
Jun 24, 2019
Merged

Merge feature.use into master #724

merged 22 commits into from
Jun 24, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 18, 2019 •
edited
Loading

nex3 added 18 commits May 17, 2019 14:40
@nex3
Continue running feature.use in use mode
19df69d
@nex3
Merge pull request #685 from sass/master-into-use
2fca9e3 
Merge master into feature.use
@nex3
Give Module a type parameter rather than making it synchronized (#686)
2317be8 
This allows us to have one fewer synchronized file, which reduces
complexity, and also lets us just write "Module" in async code rather
than "AsyncModule".
@nex3
Merge branch 'master' into master-into-use
c76ef20
@nex3
Merge pull request #690 from sass/master-into-use
04061fe 
Merge master into feature.use
@nex3
Ensure that built-in functions aren't part of a module's API (#692)
6591e31 
The way this worked previously, you could call "mod.rgb()" for any
module and it would be the same as calling the built-in rgb()
function.
@nex3
Factor out a function to load modules (#693)
f657570 
This will allow us to re-use logic for @forward. It also fixes some
usability issues where incorrect or duplicated spans were being used
for @use errors.
@nex3
Add map views to represent the ways a module can be forwarded
1ac4189
@nex3
Add support for @forward
a000bff 
See sass/sass#1094
See #554
@nex3
Improve the error message for module loops
6494951
@nex3
Merge pull request #696 from sass/forward
c5c7d4c 
Add support for @forward
@nex3
Merge branch 'master' into feature.use
e888f84
@nex3
Merge pull request #715 from sass/merge
68a3ea0 
Merge branch 'master' into feature.use
@nex3
Add built-in modules for core Sass functions (#716)
6600de2 
Partially addresses #554
@nex3
Add new module-system features for existing functions (#720)
4716349
@nex3
Add a module-variables() function
bbaa91d
@nex3
Add a module-functions() function
d89fef6
@nex3
Merge pull request #721 from sass/new-functions
339ebe8 
Add module-variables() and module-functions()
@nex3 nex3 requested review from jathak and removed request for jathak June 18, 2019 20:42
@nex3
Copy link
Contributor Author

nex3 commented Jun 18, 2019

This isn't actually ready for review yet; I want to wait until #722 has landed as well.

@nex3
Produce better stack traces for syntax errors loaded via import/use (#…
e4b18b5 
…722)

We now wrap _withStackFrame() around wider sections of code, including
_loadStylesheet() which handles parse errors, so that the @use/@import
stack frames are available.
@nex3 nex3 requested a review from jathak June 19, 2019 21:16
@nex3
Copy link
Contributor Author

nex3 commented Jun 19, 2019

Now it's ready!

jathak
jathak approved these changes Jun 21, 2019
View reviewed changes
lib/src/async_environment.dart Outdated Show resolved Hide resolved
lib/src/util/prefixed_map_view.dart Outdated Show resolved Hide resolved
lib/src/visitor/async_evaluate.dart Outdated Show resolved Hide resolved
nex3 added a commit that referenced this pull request Jun 21, 2019
@nex3
Address code review comments from #724
d9abbfa
nex3
nex3 commented Jun 21, 2019
View reviewed changes
Copy link
Contributor Author

@nex3 nex3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the thorough review! Normally for these sorts of merges you don't need to go through all the changes since they were already reviewed when they landed on feature.use, but you did find some problems so I can't complain 😅.

I've addressed your comments in #729, which I'll merge into this PR once it lands.

@nex3 nex3 mentioned this pull request Jun 24, 2019
Open
@nex3 nex3 merged commit aca7057 into master Jun 24, 2019
@nex3 nex3 deleted the merge-use branch June 24, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @jathak