-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a deprecation warning for @import's that resolved .css files #2613
Conversation
91220b0
to
b8f42cd
Compare
@nex3 feel free to word smith the deprecation warning. Linking to a specific custom importer implementation/documentation is tricky because LibSass is mostly used embedded into other projects. |
3018ac9
to
e7f2fa7
Compare
This is the first to removing native CSS imports. Like Ruby Sass, Dart Sass will not implement this behaviour. This is blocking compatibility between Node Sass and Dart Sass. This is a non-standard behaviour which is constant source of confusion. We had originally planned to removed this behaviour when the module system was ready. However that has feature has been delayed and people are continuing to be tripped up by this behaviour.
e7f2fa7
to
b4a94fc
Compare
Back ported to 3.5-stable |
Rebased this off of master since it only belongs in 3.5. |
There needs to be something somewhere that tells you what to do about this warning. It cropped up all of a sudden, and I have no idea how to make it go away. Where is the documentation about what to do when you hit this? There appears to be zero documentation about |
The resolution is to stop importing .css files. This is a non-standard feature that goes against the Sass language spec.
It's a temporary work around in the C API for integrators. It's use is highly discouraged! It is only offered a temporary polyfill to enable each implementation to migrate their users off of the invalid behaviour |
See #2611
This is the first to removing native CSS imports.
Like Ruby Sass, Dart Sass will not implement this behaviour. This is
blocking compatibility between Node Sass and Dart Sass.
This is a non-standard behaviour which is constant source of confusion.
We had originally planned to removed this behaviour when the module
system was ready. However that has feature has been delayed and
people are continuing to be tripped up by this behaviour.