Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-exists): Parameter name to "feature" #2929

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

nschonni
Copy link
Collaborator

To match Ruby/Dart Sass
Closes #2928

@nschonni
Copy link
Collaborator Author

I just eyeball'd this, so maybe i'm not correct

@nschonni nschonni requested a review from mgreter June 28, 2019 02:25
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgreter mgreter merged commit 2c22d56 into sass:master Jul 15, 2019
@nschonni nschonni deleted the fix-feature-exists-param-name branch July 15, 2019 19:39
nex3 added a commit to sass/sass-spec that referenced this pull request Jul 15, 2019
nex3 added a commit to sass/sass-spec that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature-exists()'s parameter name should be $feature
2 participants