Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature-exists() specs for sass/libsass#2929 #1434

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Update feature-exists() specs for sass/libsass#2929 #1434

merged 2 commits into from
Jul 15, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 15, 2019

This should have been landed along with sass/libsass#2929, but that
ship has sailed.

@nex3 nex3 requested a review from nschonni July 15, 2019 21:47
nschonni
nschonni approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't realize I missed the spec for this one

@nschonni nschonni self-requested a review July 15, 2019 21:52
@nex3 @nschonni
Code review change
69da0f1 
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
nschonni
nschonni approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nex3 nex3 merged commit b7cc904 into master Jul 15, 2019
@nex3 nex3 deleted the feature-exists-libsass branch July 15, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @nschonni