Merge master into feature.use #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add specs for CR, CR LF, and FF line endings
1. Changes `folder` to `dir.to_s` (`folder` no longer exists). 2. Changes `passing.any?` to `!passing.empty?`, as `any?` has pitfalls: Took me a few minutes to debug when I tried with `input_path` that was returning `nil` (`[nil].any? #=> false`).
These 2 files are used to test UTF8 paths directly with sassc executable, requiring a real directory. This special handling is required to test fully on Windows (Ruby wrapper can mask bugs), see sass/libsass#1774.
Follow-up to #1370
Drop support for Ruby Sass
These are getting in the way of removing Ruby Sass testing. Closes #1305
This reverts commit 368cfed.
Run specs from within the spec directory This means all reported paths will be relative, which makes it much easier to move specs without having to regenerate expected error messages.
This also deletes all directories with an :end_version:.
Drop support for multiple language versions
Add todo spec test for libsass issue 2863
This PR activates specs for sass/libsass#2863
Activate specs for issue 2863
Add tests for `quote`
I've tried to capture the best practices I've come up with while writing tests in the HRX format, mixed with best practices from other testing traditions and a few rules that mostly serve to just establish a consistent style.
Follow-up to #1380
Add specs for attribute selectors with modifiers
srawlins
reviewed
May 7, 2019
|
Because this is merging in #1372, which deleted the very large |
|
Perhaps this should be a rebase instead of a merge? |
|
Rebases of many commits tend to make it harder to resolve merge conflicts, and provide a less accurate view of the evolution of a branch over time. Also you can't do pull requests for them, which means you don't get CI verification of their validity before merging. |
srawlins
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip dart-sass]