Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate min length for max read size #1

Open
jayvdb opened this issue Sep 7, 2015 · 2 comments · May be fixed by #23
Open

Separate min length for max read size #1

jayvdb opened this issue Sep 7, 2015 · 2 comments · May be fixed by #23

Comments

@jayvdb
Copy link

jayvdb commented Sep 7, 2015 •
edited
Loading

https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/exceptions.py is an example of a very long docstring, which would require a large read size, however we want a low read size to avoid needing to add copyright notices to empty __init__ files.
@jayvdb
Copy link
Author

jayvdb commented Sep 7, 2015

A simple fix is jayvdb@c49be88

A better fix would be to replace the 'min' file size with a check whether the file contains any code. If it has code, it needs a copyright notice.

@jayvdb
Copy link
Author

jayvdb commented Sep 8, 2015

@xZise implemented a 'no code' check for another flake8 plugin.
xZise/flake8-future-import@caf7843#diff-29e1ed16c670c8b3c96eb9f7423d70ecR29
Would you be happy with a change implementing a similar approach for this plugin?

wmfgerrit pushed a commit to wikimedia/pywikibot that referenced this issue Aug 22, 2016
@jayvdb @xqt
Add copyright to several scripts
cc86933 
flake8-copyright isn't to be used until
savoirfairelinux/flake8-copyright#1
is solved upstream.

Detached from  Ie408e360ef686b9

Signed-off-by: xqt <info@gno.de>
Change-Id: I17106731e4da95b5a28625fe899c46aaef3afb5b
@jayvdb jayvdb mentioned this issue Sep 14, 2016
Open
@jeaboswell jeaboswell linked a pull request Sep 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate read size from copyright-min-file-size jeaboswell/flake8-copyright
1 participant
@jayvdb