Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate read size from copyright-min-file-size #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeaboswell
Copy link

Closes #1

Copy link

@manueljacob manueljacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the naming of the option, it looks good to me.

@@ -30,6 +30,10 @@ copyright-min-file-size
Minimum number of characters in a file before requiring a copyright notice. This is to avoid
forcing yourself to add copyright notices to very small or empty files. Default: ``0``.

copyright-max-read-size
Maximum number of characters to read from a file when looking for the copyright notice. This

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why “Maximum number of characters”? Isn’t it just “Number of characters"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate min length for max read size
2 participants