Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security concern #599

Closed
psmoros opened this issue Apr 24, 2023 · 1 comment · Fixed by #606
Closed

Security concern #599

psmoros opened this issue Apr 24, 2023 · 1 comment · Fixed by #606

Comments

@psmoros
Copy link

psmoros commented Apr 24, 2023

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@cruatta) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

(cc @huntr-helper)
@sbs20
Copy link
Owner

sbs20 commented Apr 24, 2023

Hi! Thank you. Please forward issues to info@sbs20.com

I will keep this issue open in order to add a policy.

@sbs20 sbs20 mentioned this issue Apr 24, 2023
Closed
sbs20 added a commit that referenced this issue May 7, 2023
@sbs20
SECURITY: CommandBuilder fixes
d51fd52 
Closes #599

This was an issue privately reported by @cruatta in #593 who also helped in resolving the issue - huge thanks!

I also updated some other unit tests to use `assert.match` for better error reporting when (if) tests are broken.
@sbs20 sbs20 mentioned this issue May 7, 2023
Merged
@sbs20 sbs20 closed this as completed in #606 May 7, 2023
sbs20 added a commit that referenced this issue May 7, 2023
@sbs20
SECURITY: CommandBuilder fixes
8314599 
Closes #599

This was an issue privately reported by @cruatta in #593 who also helped in resolving the issue - huge thanks!

I also updated some other unit tests to use `assert.match` for better error reporting when (if) tests are broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SECURITY: CommandBuilder fixes sbs20/scanservjs
2 participants
@sbs20 @psmoros