Fix handling for unknown JUnit segment types

[lihaoyi]

Necessary to get sbt-jupiter-interface working with Kotlin's Kotest com-lihaoyi/mill#4048

Rather than skipping the entire unknown segment types, we filter out "suite" segments explicitly (which appears to be what we actually need to do, e.g. in

sbt-jupiter-interface/src/library/src/main/java/com/github/sbt/junit/jupiter/internal/event/TaskName.java

Line 123 in 4391848

.filter(segment -> segment.getType().equals("suite"))

) and leave unknown segment types as space-separated. We perform a final .trim on the generated string to ensure any leading spaces are removed, since when generating the strings for each segment we do not know whether it will be the leading segment or not

This appears to have been broken in https://github.com/sbt/sbt-jupiter-interface/pull/126/files, where returning null caused the entire test identifier to not render

It's not entirely clear to me why we filter out the suite segments to begin with, but given that we do this seems like the better way to do it

[lihaoyi]

CC @jodersky @eed3si9n

[eed3si9n]

Thanks!

[jodersky]

Looks good!

…

On Mon, Dec 2, 2024, 09:36 eugene yokota ***@***.***> wrote: ***@***.**** approved this pull request. Thanks! — Reply to this email directly, view it on GitHub <#128 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHV3JAH7HBS6JBLVOZFX6D2DQLZJAVCNFSM6AAAAABS2OUK76VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZSGA2TEMJVHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[lihaoyi]

Thanks for the reviews! @eed3si9n could we merge and publish this?

[eed3si9n]

done - https://github.com/sbt/sbt-jupiter-interface/releases/tag/v0.13.3

[lihaoyi]

Thanks! Will give it a spin