bump sbt-jupiter-interface to 0.13.3 #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the latest changes fixed the issue on the java side, but there remains some issues on the Kotlin Kotest/junit integration causing test class and test case names not to be reported |
|
sbt/sbt-jupiter-interface#128 should fix the kotlin side |
eed3si9n
pushed a commit
to sbt/sbt-jupiter-interface
that referenced
this pull request
Dec 2, 2024
Necessary to get sbt-jupiter-interface working with Kotlin's Kotest com-lihaoyi/mill#4048 Rather than skipping the entire unknown segment types, we filter out `"suite"` segments explicitly (which appears to be what we actually need to do, e.g. in https://github.com/sbt/sbt-jupiter-interface/blob/43918484453f25ae8e852fae48d54d84be77e0fe/src/library/src/main/java/com/github/sbt/junit/jupiter/internal/event/TaskName.java#L123) and leave unknown segment types as space-separated. We perform a final `.trim` on the generated string to ensure any leading spaces are removed, since when generating the strings for each segment we do not know whether it will be the leading segment or not This appears to have been broken in https://github.com/sbt/sbt-jupiter-interface/pull/126/files, where returning `null` caused the entire test identifier to not render It's not entirely clear to me why we filter out the `suite` segments to begin with, but given that we do this seems like the better way to do it
lihaoyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying this after fixes were merged upstream
Supersedes #3988