Skip to content

Commit

Permalink
Change openjdk:latest to openjdk:8 because the latest version of open…
Browse files Browse the repository at this point in the history
…jdk has moved to Java 10, which is not fully compatible with Scala. (#1147)
  • Loading branch information
wjlow authored and muuki88 committed Aug 7, 2018
1 parent b042f6a commit c17d298
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ object DockerPlugin extends AutoPlugin {
override def projectConfigurations: Seq[Configuration] = Seq(Docker)

override lazy val projectSettings: Seq[Setting[_]] = Seq(
dockerBaseImage := "openjdk:latest",
dockerBaseImage := "openjdk:8",
dockerExposedPorts := Seq(),
dockerExposedUdpPorts := Seq(),
dockerExposedVolumes := Seq(),
Expand Down
2 changes: 1 addition & 1 deletion src/sbt-test/docker/override-commands/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ maintainer := "Gary Coady <gary@lyranthe.org>"

dockerUpdateLatest := true
dockerCommands := Seq(
Cmd("FROM", "openjdk:latest"),
Cmd("FROM", "openjdk:8"),
Cmd("LABEL", s"""MAINTAINER="${maintainer.value}""""),
ExecCmd("CMD", "echo", "Hello, World from Docker")
)
4 changes: 2 additions & 2 deletions src/sphinx/formats/docker.rst
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ In your sbt console type
.. code-block:: bash
> show dockerCommands
[info] List(Cmd(FROM,openjdk:latest), Cmd(LABEL,MAINTAINER=Your Name <y.n@yourcompany.com>), ...)
[info] List(Cmd(FROM,openjdk:8), Cmd(LABEL,MAINTAINER=Your Name <y.n@yourcompany.com>), ...)
Expand Down Expand Up @@ -311,7 +311,7 @@ Now let's start adding some Docker commands.
import com.typesafe.sbt.packager.docker._
dockerCommands := Seq(
Cmd("FROM", "openjdk:latest"),
Cmd("FROM", "openjdk:8"),
Cmd("LABEL", s"""MAINTAINER="${maintainer.value}""""),
ExecCmd("CMD", "echo", "Hello, World from Docker")
)
Expand Down

0 comments on commit c17d298

Please sign in to comment.