Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change openjdk:latest to openjdk:8. #1147

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Change openjdk:latest to openjdk:8. #1147

merged 1 commit into from
Aug 7, 2018

Conversation

wjlow
Copy link
Contributor

@wjlow wjlow commented Aug 7, 2018

Because the latest version of openjdk has moved to Java 10, which is not fully compatible with Scala.

This resolves #1146

…jdk has moved to Java 10, which is not fully compatible with Scala.
@lightbend-cla-validator
Copy link

Hi @wjlow,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks! 🤩
Once CI has passed and CLA is signed, this is ready to merge.

@wjlow
Copy link
Contributor Author

wjlow commented Aug 7, 2018

I've signed the CLA! Thanks.

@muuki88 muuki88 merged commit c17d298 into sbt:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default dockerBaseImage value should be set to Java 8.
3 participants