Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back sbt-header #332

Closed
eed3si9n opened this issue Jul 3, 2017 · 2 comments
Closed

Bring back sbt-header #332

eed3si9n opened this issue Jul 3, 2017 · 2 comments

Comments

@eed3si9n
Copy link
Member

eed3si9n commented Jul 3, 2017

sbt-header was removed in #323

@jvican
Copy link
Member

jvican commented Jul 7, 2017

This is a ticket for the Scala Center spree at Scala Wave (Gdansk, Poland).

To solve this issue, sbt-header has to be cross-built to sbt 1.0.0-M6. To get an example of how to cross-build sbt header, you have to:

  1. Update the sbt build to 0.13.16-M1.
  2. Create a scala file in project called CrossBuildingPlugin.scala, getting the contents from here.
  3. Fixing the scala version for the sbt version.

A good example is the following commit, which shows some of these steps. Note that the commit fixes some other stuff. The diff you'll get will be smaller.

Another example of a plugin that cross-builds to sbt 0.13 and 1.0 is sbt-structure.

This is a good ticket to improve your sbt skills, especifically if you want to port OSS projects or your company's projects to the latest, faster sbt 1.0.0.

@odisseus
Copy link

odisseus commented Jul 7, 2017

@jvican, the link to CrossBuildingPlugin points to this same page. It probably should have pointed here.

jvican added a commit to scalacenter/zinc that referenced this issue Oct 12, 2017
@jvican jvican removed the spree label Oct 26, 2017
jvican added a commit to scalacenter/zinc that referenced this issue Nov 13, 2017
dwijnand added a commit to dwijnand/zinc that referenced this issue Nov 22, 2017
* 1.0.x: (25 commits)
  Add yourkit acknoledgement in the README
  Add header to cached hashing spec
  Add headers to missing files
  Fix sbt#332: Add sbt-header back to the build
  Update sbt-scalafmt to 1.12
  Make classpath hashing more lightweight
  Fix sbt#442: Name hash of value class should include underlying type
  source-dependencies/value-class-underlying: fix test
  Ignore null in generic lambda tparams
  Improve and make scripted parallel
  Fix sbt#436: Remove annoying log4j scripted exception
  Fix sbt#127: Use `unexpanded` name instead of `name`
  Add pending test case for issue/127
  source-dependencies / patMat-scope workaround
  Fixes undercompilation on inheritance on same source
  Add real reproduction case for sbt#417
  Add trait-trait-212 for Scala 2.12.3
  Fix source-dependencies/sealed
  Import statement no longer needed
  Move mima exclusions to its own file
  ...

 Conflicts:
	internal/zinc-apiinfo/src/main/scala/sbt/internal/inc/ClassToAPI.scala
	zinc/src/main/scala/sbt/internal/inc/MixedAnalyzingCompiler.scala

The ClassToAPI conflict is due to:
* sbt#393 (a 1.x PR), conflicting with
* sbt#446 (a 1.0.x PR).

The MixedAnalyzingCompiler conflict is due to:
* sbt#427 (a 1.x PR), conflicting with
* sbt#452 (a 1.0.x PR).
dwijnand added a commit to dwijnand/zinc that referenced this issue Nov 23, 2017
* 1.0.x: (28 commits)
  Split compiler bridge tests to another subproject
  Implement compiler bridge for 2.13.0-M2
  Add yourkit acknoledgement in the README
  "sbt '++ 2.13.0-M2!' compile" does not work with sbt 1.0.0
  Add header to cached hashing spec
  Add headers to missing files
  Fix sbt#332: Add sbt-header back to the build
  Update sbt-scalafmt to 1.12
  Make classpath hashing more lightweight
  Fix sbt#442: Name hash of value class should include underlying type
  source-dependencies/value-class-underlying: fix test
  Ignore null in generic lambda tparams
  Improve and make scripted parallel
  Fix sbt#436: Remove annoying log4j scripted exception
  Fix sbt#127: Use `unexpanded` name instead of `name`
  Add pending test case for issue/127
  source-dependencies / patMat-scope workaround
  Fixes undercompilation on inheritance on same source
  Add real reproduction case for sbt#417
  Add trait-trait-212 for Scala 2.12.3
  ...

 Conflicts:
	internal/zinc-apiinfo/src/main/scala/sbt/internal/inc/ClassToAPI.scala
	project/build.properties
	zinc/src/main/scala/sbt/internal/inc/MixedAnalyzingCompiler.scala

The ClassToAPI conflict is due to:
* sbt#393 (a 1.x PR), conflicting with
* sbt#446 (a 1.0.x PR).

The build.properties conflict is due to different PRs bumping
sbt.version from 1.0.0 to 1.0.2 to 1.0.3. (sbt#413, sbt#418, sbt#453).

The MixedAnalyzingCompiler conflict is due to:
* sbt#427 (a 1.x PR), conflicting with
* sbt#452 (a 1.0.x PR).
@jvican jvican closed this as completed in 90da1fb Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants