neo-sbt-scalafmt and making LoggedReporter extensible #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
You'll have to tweak bin/run-ci.sh if you want to switch scalafmt plugin: https://github.com/sbt/zinc/pull/392/files#diff-4a4612d6cdda9aac96abca1deae9ec85R11. Also the reason we're not already using neo-sbt-scalafmt is because of the CI issues I was seeing in #392. |
|
@dwijnand Seems like Drone passed. |
|
Can you reorder the commits in such a way that all commits pass CI? |
I get NPE when I extend ManagedLoggedReporter if I don't do this.
eed3si9n
force-pushed
the
wip/LoggedReporter
branch
from
cde592d
to
264ffc5
Compare
|
@jvican Done. |
jvican
approved these changes
Sep 25, 2017
|
The validator has checked the following projects against Scala 2.12,
❌ The result is: FAILED |
dwijnand
added a commit
to dwijnand/zinc
that referenced
this pull request
Nov 23, 2017
* 1.0.x: (28 commits) Split compiler bridge tests to another subproject Implement compiler bridge for 2.13.0-M2 Add yourkit acknoledgement in the README "sbt '++ 2.13.0-M2!' compile" does not work with sbt 1.0.0 Add header to cached hashing spec Add headers to missing files Fix sbt#332: Add sbt-header back to the build Update sbt-scalafmt to 1.12 Make classpath hashing more lightweight Fix sbt#442: Name hash of value class should include underlying type source-dependencies/value-class-underlying: fix test Ignore null in generic lambda tparams Improve and make scripted parallel Fix sbt#436: Remove annoying log4j scripted exception Fix sbt#127: Use `unexpanded` name instead of `name` Add pending test case for issue/127 source-dependencies / patMat-scope workaround Fixes undercompilation on inheritance on same source Add real reproduction case for sbt#417 Add trait-trait-212 for Scala 2.12.3 ... Conflicts: internal/zinc-apiinfo/src/main/scala/sbt/internal/inc/ClassToAPI.scala project/build.properties zinc/src/main/scala/sbt/internal/inc/MixedAnalyzingCompiler.scala The ClassToAPI conflict is due to: * sbt#393 (a 1.x PR), conflicting with * sbt#446 (a 1.0.x PR). The build.properties conflict is due to different PRs bumping sbt.version from 1.0.0 to 1.0.2 to 1.0.3. (sbt#413, sbt#418, sbt#453). The MixedAnalyzingCompiler conflict is due to: * sbt#427 (a 1.x PR), conflicting with * sbt#452 (a 1.0.x PR).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two relatively minor changes here.
First is the adoption of neo-sbt-scalafmt. Without it I can't use emulated monorepo because all other modules are using neo-sbt-scalafmt.
Second, I am turning all the fields in
LoggedReporterlazy. Without the change I get NPE when extending ManagedLoggedReporter for LSP. I think this is because ctor callsresetat line 107, and I am overriding it in the subclass, so it could get called before all fields are initialized. (Initialization still confuses me.) No other observable changes are expected.