Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing preferred filter for getting symbol completions #17706

Closed
vzmerr opened this issue Jul 22, 2022 · 1 comment · Fixed by #19850
Closed

passing preferred filter for getting symbol completions #17706

vzmerr opened this issue Jul 22, 2022 · 1 comment · Fixed by #19850
Assignees
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:enhancement
Milestone

Comments

@vzmerr
Copy link

vzmerr commented Jul 22, 2022

Currently for the following sample code, which requires a fuzzy completion:

object Main {
   type MyType = List[Int]
   def list : MT@@
}

dotty completions does not return a result.

It seems to be due to a filter .startsWith(prefix) somewhere.

If would be cool, if the API allows for the passing of a preferred filter instead, so that results like MyType which do not pass the existing filter, can also be retrieved when desired.

This has application in Scala 3 type completions in Metals.

@tgodzik
Copy link
Contributor

tgodzik commented Jul 29, 2022

I think it would actually be good to move it to the main repo since it's blocking us a bit in terms of UX.

@ckipp01 ckipp01 transferred this issue from lampepfl/dotty-feature-requests May 31, 2023
@ckipp01 ckipp01 added the stat:needs triage Every issue needs to have an "area" and "itype" label label May 31, 2023
@nicolasstucki nicolasstucki added area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Jan 10, 2024
rochala added a commit that referenced this issue Apr 12, 2024
…mpiler) (#19850)

Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
olhotak pushed a commit to dotty-staging/dotty that referenced this issue Apr 15, 2024
…mpiler) (scala#19850)

Fixes scalameta/metals#4656
Fixes scala#5507
Fixes scala#17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
WojciechMazur added a commit that referenced this issue Jul 5, 2024
…mpiler) (#19850)

Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
[Cherry-picked acfc621][modified]
WojciechMazur added a commit that referenced this issue Jul 5, 2024
…mpiler) (#19850)

Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
[Cherry-picked acfc621][modified]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants