-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Scala 3) completions are more sensitive than Scala 2's #4656
Comments
Thanks for reporting! The issue is that the compiler is trying to filter the results first, we need to change that upstream I think. |
We would need to change it around here https://github.com/lampepfl/dotty/blob/main/compiler/src/dotty/tools/dotc/interactive/Completion.scala#L136 |
|
yep, Scala 2 allowed the downstream tools to use any kind of matcher |
…mpiler) (#19850) Fixes scalameta/metals#4656 Fixes #5507 Fixes #17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19]
…mpiler) (scala#19850) Fixes scalameta/metals#4656 Fixes scala#5507 Fixes scala#17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19]
…mpiler) (#19850) Fixes scalameta/metals#4656 Fixes #5507 Fixes #17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19] [Cherry-picked acfc621][modified]
…mpiler) (#19850) Fixes scalameta/metals#4656 Fixes #5507 Fixes #17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19] [Cherry-picked acfc621][modified]
Describe the bug
In Scala 3 completions, it seems like whatever algorithm was used for fuzzy finding in Scala 2 has been changed to a more strict one. It's limiting the amount of completions that you get, and could be considered a defect in the functionality.
To reproduce:
If you start typing at
<CURSOR>
and writem
, you'll see a completion for the method:In Scala 3, you don't see it:
Expected behavior
The method completion shows up.
Operating system
macOS
Editor/Extension
VS Code
Version of Metals
v0.11.9
Extra context or search terms
No response
The text was updated successfully, but these errors were encountered: