Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't retypecheck erroneous arguments when fixing function #14043

Merged
merged 7 commits into from
Jan 24, 2022
Merged

Don't retypecheck erroneous arguments when fixing function #14043

merged 7 commits into from
Jan 24, 2022

Commits on Jan 24, 2022

  1. Don't retypecheck erroneous arguments when fixing function 

    Don't retypecheck erroneous arguments when trying conversions or extensions
on the function part.

Generally, we should avoid typechecking untyped trees several times, this can quickly
explode exponentially.

Fixes scala#12941
    @odersky
    odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    002f9a0 View commit details
    Browse the repository at this point in the history

  2. Refine condition when to not typecheck again 

    Only count errors that lead to an error type in some subtree as unrecoverable.
    @odersky
    odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a3e2840 View commit details
    Browse the repository at this point in the history

  3. Further refine condition when not to typecheck again 

    This should fix the failures in spire and specs2.
    @odersky
    odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    fcf2560 View commit details
    Browse the repository at this point in the history

  4. Disable protoquill 

    Protquill had to be disabled since it exhibited deeply nested errors in a function argument that went away
once an enclosing function was changed with a conversion or extension, and the full argument was completely typechecked.
Retype checking large bodies of code like this was never inteneded and counts as a bug in the compiler. Unfortunately,
this means that some type annotations will have to be added to protoquill to make it compiler again.
    @odersky
    odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    87fc207 View commit details
    Browse the repository at this point in the history

  5. Harden hasInnerErrors and fix tests

    @odersky
    odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    4d0d205 View commit details
    Browse the repository at this point in the history

  6. Revert "Disable protoquill" 

    This reverts commit ea8d8b6.
    @odersky
    odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    ee015bc View commit details
    Browse the repository at this point in the history

  7. Fix protoquill 

    Cherry-pick changes from zio/zio-protoquill@5ed25aa
also present in zio/zio-quill#2379.
    @nicolasstucki @odersky
    nicolasstucki authored and odersky committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    89ec460 View commit details
    Browse the repository at this point in the history