Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect -P:semanticdb:targetroot #882

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

olafurpg
Copy link
Contributor

This makes it possible for users to place SemanticDB files in a
different directory than classDirectory and still use Scalafix.

It turns out some cli tests were passing by accident because the
classloader we used to load SemanticDB already included the missing
SemanticDB files thanks to the parent classloader. After this commit,
the classloader has no parent so that the test fixture doesn't
accidentally pick up resources from the parent classloader.

Fixes #879

This makes it possible for users to place SemanticDB files in a
different directory than classDirectory and still use Scalafix.

It turns out some cli tests were passing by accident because the
classloader we used to load SemanticDB already included the missing
SemanticDB files thanks to the parent classloader. After this commit,
the classloader has no parent so that the test fixture doesn't
accidentally pick up resources from the parent classloader.
@olafurpg olafurpg merged commit fa1c521 into scalacenter:master Sep 21, 2018
@olafurpg olafurpg deleted the targetroot branch September 21, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-P:semanticdb:targetroot is not used
1 participant