Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.4.0 #213

Closed

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-sbt:sbt from 1.3.13 to 1.4.0.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-minor

@tgodzik
Copy link
Contributor

tgodzik commented Oct 5, 2020

We should hold of on this until the issues with Dotty are fixed. But also, how does updating sbt break so many tests? 😨

@olafurpg
Copy link
Member

olafurpg commented Oct 5, 2020

The failing tests look Yrangepos related 🤔

==> X munit.ClueSuite.list  0.001s munit.FailException: /home/runner/work/munit/munit/tests/shared/src/test/scala/munit/ClueSuite.scala:56
55:  val z: List[Int] = List(1)
56:  checkPrint(
57:    "list",
diff assertion failed
=> Obtained
    """|Clues {
       |  : List[Int] = List(
       |    1
       |  )
       |}
       |""".stripMargin
=> Diff (- obtained, + expected)
 Clues {
-  : List[Int] = List(
+  z: List[Int] = List(
     1

@SethTisue
Copy link
Contributor

I'm seeing the same failures in the Scala community build, after moving from 1.4.0-RC2 to 1.4.0 final.

@eed3si9n @eatkins any idea what could have changed between 1.4.0-RC2 and 1.4.0 that could be causing this? I don't see any obvious candidates in the git logs.

@eed3si9n
Copy link
Contributor

eed3si9n commented Oct 5, 2020

I opened sbt/sbt#5934.

@mzuehlke mzuehlke mentioned this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants