-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sbt versions #313
update sbt versions #313
Conversation
The fact that the tests are failing here is very unsettling 😰 |
Partial investigation:
|
oh, I found a ticket on this: sbt/sbt#5934 |
I admit I've never bothered to upgrade Sbt because I didn't want to get into that issue 😅 Wild guess: something related to escaping of output? It seems that the value names are not being printed |
Updates didn't worked since sbt version 1.4.0. |
It's not a printing problem. In |
Wow. The fact that this has something to do with sbt is deeply unnerving 😳 I'll take a look when I have a minute |
It looks like |
@larsrh Nice find, that would explain the differences between 2.11/2.12 and 2.13 |
It's definitely the |
I can confirm the workaround proposed by @mpilquist works locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, just a minor comment 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thank you @larsrh and everyone who contributed to this distributed bug hunt!
Subsumes #304 and #301