Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Scala 3.0.0-RC1 #312

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Update to Scala 3.0.0-RC1 #312

merged 1 commit into from
Feb 16, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Feb 16, 2021

Fixes #311

@tgodzik tgodzik mentioned this pull request Feb 16, 2021
Closed
gabro
gabro reviewed Feb 16, 2021
View reviewed changes
munit/shared/src/main/scala-3.0.0-RC1/munit/internal/MacroCompat.scala Outdated
@@ -0,0 +1,52 @@
package munit.internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reason for this compat file? (out of curiosity)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can probably remove the equivalent M2 file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change val source = value.asTerm.pos.sourceCode.getOrElse("")

Maybe that is already thee in M3 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems worth trying

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems to compile ok. Though I am still following up about the docs.

@larsrh
Copy link
Contributor

larsrh commented Feb 16, 2021

Created a PR for sbt updates: #313

@gabro
Copy link
Member

gabro commented Feb 16, 2021

Now that #313 is in, rebasing this should fix all the outstanding issues 🤞

@tgodzik tgodzik force-pushed the update-3.0.0-RC1 branch 2 times, most recently from 63ad20d to 9df3860 Compare February 16, 2021 20:41
gabro
gabro reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the compatibility table in the docs

@tgodzik
Copy link
Contributor Author

tgodzik commented Feb 16, 2021

We also need to update the compatibility table in the docs

I think that's updated automatically.

gabro
gabro reviewed Feb 16, 2021
View reviewed changes
build.sbt
Comment on lines +255 to +258
if (isNotScala211(partialVersion))
"org.scalacheck" %%% "scalacheck" % "1.15.3"
else
"org.scalacheck" %%% "scalacheck" % "1.15.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgodzik / @olafurpg I wonder when will it be a good time to start dropping 2.11 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ScalaCheck has dropped 2.11 then I won’t oppose dropping it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 2.11 in Metals so maybe it’s worth supporting for that usecase alone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I would then probably defer it to when Metals will drop 2.11 (it seems fair to do it in a bit, since native is now supporting more recent Scala versions)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2.11 is still quite heavily used by companies on spark. I have mixed feelings about having deprecated 2.11 in Metals. I haven’t looked at the download numbers to confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's look at the numbers and see what's the situation. On one end, those numbers are indicative, but on the other they're not independent: if the ecosystem nudges you to move forward, you probably do, at some point. And Metals is part of the ecosystem.

@gabro
Copy link
Member

gabro commented Feb 16, 2021

I think that's updated automatically.

@tgodzik you're right, sometimes I forgets this nice treats of automation 🍬

@gabro
Copy link
Member

gabro commented Feb 16, 2021 •
edited
Loading

@tgodzik found this reference to M2:

munit/tests/shared/src/test/scala/munit/BaseSuite.scala

Line 19 in 8034155

test.tags(OnlyFromM3) && "3.0.0-M2" == BuildInfo.scalaVersion

We can probably remove the OnlyFromM3 tag altogether.

Plus we need to update the test-release script

@tgodzik
Copy link
Contributor Author

tgodzik commented Feb 16, 2021

Thanks @gabro! I think it should be finally ready 😅

@tgodzik tgodzik marked this pull request as ready for review February 16, 2021 21:12
gabro
gabro approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! :shipit:

@gabro gabro merged commit 63b8286 into scalameta:main Feb 16, 2021
@tgodzik tgodzik deleted the update-3.0.0-RC1 branch February 16, 2021 21:16
tgodzik pushed a commit to tgodzik/munit that referenced this pull request Feb 16, 2021
@gabro @tgodzik
Merge pull request scalameta#312 from tgodzik/update-3.0.0-RC1
e6500fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg left review comments

@gabro gabro gabro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release for Scala 3.0.0-RC1, please?
4 participants
@tgodzik @larsrh @gabro @olafurpg