Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3.0.0 #359

Merged
merged 1 commit into from
May 13, 2021
Merged

Scala 3.0.0 #359

merged 1 commit into from
May 13, 2021

Conversation

gabro
Copy link
Member

@gabro gabro commented May 11, 2021

It's not out yet, but since it may be this week, I figured we could use some head start 😅

@@ -10,8 +10,7 @@ def previousVersion = "0.7.0"
def scala213 = "2.13.4"
def scala212 = "2.12.13"
def scala211 = "2.11.12"
def scala3Stable = "3.0.0-RC3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave RC3 for a while if possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth it to keep supporting RCs when a stable is out? I was always under the impression that we would drop everything priori after the stable is out.

Is this for Metals support?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we could do is to drop the support, but backpublish 3.0.0 for 0.7.25. So we the next release would drop RC3, but in the meantime we can keep using 0.7.25 for both 3.0.0 and 3.0.0-RC3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can work around it in Metals for sure, just last time we dropped to one version there was a bit of a backlash, since people would need to update munit and Scala version at the same time.

Copy link
Member Author

@gabro gabro May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I think @djspiewak had some opinion about this. Maybe also @larsrh can chime in?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds fine. I generally avoid backpublishing since it requires manual local steps that’s easy to mess up compared to automated CI releases. It’s a bummer because backpublishing is very user friendly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes, please keep two versions, it makes upgrading easier.
  2. I try to backpublish wherever I can (at least ScalaCheck and Discipline). Given the choice between "harder for me" and "harder for users", I pick "harder for me" 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try backpublishing. I've done it quite a few times in the past week for some internal projects, so I'm more confident than I usually would be in doing so :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that works, I could backpublish all the way to Cats <3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, I've made a mistake backpublishing (feeling too confident, I knew it!) plus it turns out that backpublishing other typelevel libraries would be hard (due to old sbt-dotty versions), so I've restored RC3 support and I'll merge this and cut 0.7.26

@julienrf
Copy link

Could you run the CI again?

@larsrh
Copy link
Contributor

larsrh commented May 13, 2021

It's not yet synced to Central.

@gabro
Copy link
Member Author

gabro commented May 13, 2021

@julienrf I don't think it landed on Maven Central yet (it's on sonatype though!)

@gabro
Copy link
Member Author

gabro commented May 13, 2021

The CI will still fail until Scalacheck is published, but Lars is on it

@larsrh
Copy link
Contributor

larsrh commented May 13, 2021

@gabro
Copy link
Member Author

gabro commented May 13, 2021

MUnit successfully backpublished 🎉

except I made a mistake and I've backpublished from master instead of using the 0.7.25 tag, so now MUnit 0.7.25 for Scala 3 uses Scalacheck 1.15.4, instead of 1.15.3. I'll cut a 0.7.26 release for both RC3 and stable

@tgodzik
Copy link
Contributor

tgodzik commented May 13, 2021

MUnit successfully backpublished tada

except I made a mistake and I've backpublished from master instead of using the 0.7.25 tag, so now MUnit 0.7.25 for Scala 3 uses Scalacheck 1.15.4, instead of 1.15.3. I'll cut a 0.7.26 release for both RC3 and stable

I think you might have also used JDK 11 by mistake, so it's not possible to use from 8.

Publishing by hand is evil 😅

@gabro gabro marked this pull request as ready for review May 13, 2021 14:56
@gabro
Copy link
Member Author

gabro commented May 13, 2021

I think you might have also used JDK 11 by mistake, so it's not possible to use from 8.

what's the issue with Java 8?

Publishing by hand is evil 😅

I sinned, and I have been punished, I'll let the CI do its magic from now on

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik
Copy link
Contributor

tgodzik commented May 13, 2021

I think you might have also used JDK 11 by mistake, so it's not possible to use from 8.

what's the issue with Java 8?

I tried to run mdoc tests for 3.0.0 and getting:

==> X tests.worksheets.WorksheetSuite.expected error running tests  0.003s java.lang.UnsupportedClassVersionError: munit/IgnoreSuite has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
[error] Failed: Total 1, Failed 1, Errors 0, Passed 0
[error] Failed tests:
[error]         tests.worksheets.WorksheetSuite
[error] (worksheets / Test / test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 13 s, completed May 13, 2021 4:55:50 PM

@gabro
Copy link
Member Author

gabro commented May 13, 2021

I tried to run mdoc tests for 3.0.0 and getting:

I'll add a note to the release just in case 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants