Test support for stubs compiled with Scala 3 & publish codegen for Scala 3 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Jun 28, 2021
| @@ -1,6 +1,6 @@ | |||
| addSbtPlugin("com.thesamet" % "sbt-protoc" % "1.0.4") | |||
|
|
|||
| libraryDependencies += "com.thesamet.scalapb" %% "compilerplugin" % "0.11.1" | |||
| libraryDependencies += "com.thesamet.scalapb" %% "compilerplugin" % "0.11.4" | |||
There was a problem hiding this comment.
Test updates * refined uses macro that are not available in Scala 3 * type of implicit definition needs to be given explicitly * customize "implicit not found" error message
bjaglin
commented
Jun 28, 2021
| @@ -32,7 +32,7 @@ inThisBuild( | |||
|
|
|||
| val pgvVersion = "0.4.1" | |||
| val munitSettings = Seq( | |||
| libraryDependencies += "org.scalameta" %% "munit" % "0.7.25" % Test, | |||
| libraryDependencies += "org.scalameta" %% "munit" % "0.7.26" % Test, | |||
There was a problem hiding this comment.
bjaglin
commented
Jun 28, 2021
Comment on lines
+100
to
+101
| // avoids "Not found: type UnusedPrivateParameter" in scalapb/scalapb/validate/Validate.java with Scala 3 | ||
| Compile / compileOrder := CompileOrder.JavaThenScala |
There was a problem hiding this comment.
Looks like bug in dotty. Without this:
[info] compiling 19 Scala sources and 3 Java sources to /home/bjaglin/git/projects/scalapb-validate/code-gen/target/jvm-3/classes ...
[error] -- [E006] Not Found Error: /home/bjaglin/git/projects/scalapb-validate/code-gen/target/jvm-3/src_managed/main/scalapb/scalapb/validate/Validate.java:152:8
[error] 152 | UnusedPrivateParameter unused) {
[error] | ^^^^^^^^^^^^^^^^^^^^^^
[error] | Not found: type UnusedPrivateParameter
[error] -- [E006] Not Found Error: /home/bjaglin/git/projects/scalapb-validate/code-gen/target/jvm-3/src_managed/main/scalapb/scalapb/validate/Validate.java:1209:8
[error] 1209 | UnusedPrivateParameter unused) {
[error] | ^^^^^^^^^^^^^^^^^^^^^^
[error] | Not found: type UnusedPrivateParameter
[error] -- [E006] Not Found Error: /home/bjaglin/git/projects/scalapb-validate/code-gen/target/jvm-3/src_managed/main/scalapb/scalapb/validate/Validate.java:1834:8
[error] 1834 | UnusedPrivateParameter unused) {
[error] | ^^^^^^^^^^^^^^^^^^^^^^
[error] | Not found: type UnusedPrivateParameter
[error] -- [E006] Not Found Error: /home/bjaglin/git/projects/scalapb-validate/code-gen/target/jvm-3/src_managed/main/scalapb/scalapb/validate/Validate.java:2386:8
[error] 2386 | UnusedPrivateParameter unused) {
[error] | ^^^^^^^^^^^^^^^^^^^^^^
[error] | Not found: type UnusedPrivateParameterThere was a problem hiding this comment.
It looks like this static inner class is a recurring source of problems scala/bug#9111 (comment)
There was a problem hiding this comment.
Looks like ScalaPB went this way as well to workaround the issue scalapb/ScalaPB@c4f9ce9#diff-dd3701b993fcc974a9a6d017159aac00d4b41bcd05ad319815c6001311c669d5R66
bjaglin
changed the title
|
Thanks, this got in via 03da6a7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.