Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Update FEDn logo in sidebar Issue/#235 #236

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Update FEDn logo in sidebar Issue/#235 #236

merged 3 commits into from
Oct 13, 2021

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Sep 24, 2021

Status

  • Ready
  • Draft
  • Hold

Description

See issue #235

Types of changes

What types of changes does your code introduce to STACKn?

  • Hotfix (fixing a critical bug in production)
  • Bugfix
  • New feature
  • Documentation update

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have read the CONTRIBUTING doc
  • I have included tests to complement my changes
  • I have updated the related documentation (if necessary)
  • I have updated the release notes (docs/releasenotes.md)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request

Further comments

Had to remove dist/ from .gitignore to add fedn logo

@Wrede Wrede added the bug Something isn't working label Sep 24, 2021
@Wrede Wrede self-assigned this Sep 24, 2021
Copy link
Contributor

@carmat88 carmat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to have the FEDn logo directly under the main dist folder, like the STACKn logo.

@morganekmefjord morganekmefjord merged commit 6a059bd into develop Oct 13, 2021
@morganekmefjord morganekmefjord deleted the issue/#235 branch October 13, 2021 06:01
@carmat88 carmat88 mentioned this pull request Oct 26, 2021
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants