Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creation of public IP-less servers via special IP address names #283

Merged
merged 2 commits into from
Feb 25, 2016

Conversation

ElNounch
Copy link
Contributor

No description provided.

@moul
Copy link
Contributor

moul commented Feb 21, 2016

Thank you @ElNounch, it looks good to me


@QuentinPerez, can you give a try tomorrow to see if every cases are handled ?

We will also need to:

  • Update the Changelog
  • Add usage examples in README.md
  • Add usage examples in scw create -h
  • Port this to scw run too

@QuentinPerez
Copy link
Contributor

Tested and LGTM 😃

@ElNounch
Copy link
Contributor Author

Commited port to scw run in what should be a retro-compatible way.

@QuentinPerez
Copy link
Contributor

Thank you @ElNounch 😉

QuentinPerez pushed a commit that referenced this pull request Feb 25, 2016
Enable creation of public IP-less servers via special IP address names
@QuentinPerez QuentinPerez merged commit 3cce3a5 into scaleway:master Feb 25, 2016
@moul
Copy link
Contributor

moul commented Feb 25, 2016

@QuentinPerez, can you update the Changelog ?

@ElNounch ElNounch deleted the ip-address-none branch February 29, 2016 21:52
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants