Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining --no-dynamic-ip command line flag and NoDynamicIP member of … #284

Closed
wants to merge 1 commit into from

Conversation

ElNounch
Copy link
Contributor

…struct CreateArgs

@moul
Copy link
Contributor

moul commented Feb 21, 2016

Related with #283, @QuentinPerez can you check both pull-requests at the same time ?

@QuentinPerez
Copy link
Contributor

Hi @ElNounch thank you for your PRs

With this solution, we have a conflict between --no-dynamic and --ip-address

$> ./scw create --no-dynamic-ip --ip-address='212.47.226.27' ubuntu-wily
$> ./scw inspect 00000000-0000-1000-0000-000000000000| jq '.[0].public_ip'
{
  "id": "00000000-0000-1000-0000-000000000000",
  "address": "212.47.226.27",
  "dynamic": false
}

Personally, I prefer this solution #283, I think that it is more readable and does not add complexity

@QuentinPerez
Copy link
Contributor

We have merged #283 instead

@ElNounch ElNounch deleted the no-dynamic-ip branch February 25, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants