Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video "About" section contains "homepage" – link to self #659

Open
1 task
Tracked by #660
, #673
...
jillpe opened this issue Jul 22, 2024 · 0 comments
Open
1 task
Tracked by #660
, #673
...

Video "About" section contains "homepage" – link to self #659

jillpe opened this issue Jul 22, 2024 · 0 comments
Assignees
@sjproctor
Labels
good first issue Good for newcomers Pre-Launch

Comments

@jillpe
Copy link

jillpe commented Jul 22, 2024 •
edited by sjproctor
Loading

Summary

reference : https://docs.google.com/spreadsheets/d/1XbfCosfI_P3N2JVYldD28p6Ca6AxNRbAOKbOcp1GRgo/edit?gid=0#gid=0

Resource page for video - more info/about section in the UV, is linking to the object.

UTK would like to relabel this field

Acceptance Criteria

  • The link that takes the user to the object in the more info/about section is relabeled to "Link to item"

Testing Instructions

  • Select Audio item i673 About Test, scroll to the Items section at the bottom of the page, click on the title i673 About Test ()
  • See the About section on the right hand side
@jillpe jillpe added this to utk-hyku Jul 22, 2024
@jillpe jillpe converted this from a draft issue Jul 22, 2024
@jillpe jillpe changed the title PDF downloads do not download with extension – on Mac, these open in TextEdit Video "About" section contains "homepage" – link to self Jul 22, 2024
@jillpe jillpe mentioned this issue Jul 22, 2024
Open
15 tasks
@orangewolf orangewolf added the good first issue Good for newcomers label Jul 23, 2024
@sjproctor sjproctor moved this to In Development in utk-hyku Jul 30, 2024
sjproctor added a commit that referenced this issue Jul 30, 2024
@sjproctor
🎁 change clover iiif about > homepage label
edd1582 
Our approach was to edit the source file of clover iiif to change the
label of `"Homepage"` to `"Link to item"`. We also noticed the link
opened within the iFrame creating a nested webpage. So we added a target
parent to the link.

Went into the JavaScript file and searched for `"Homepage"` and replaced
the text with `"Link to item"`.
To fix the nested page we looked for `rw=function` and added
`,target:"_parent"` to the end of the function (after `key:t.id`)

Ref:
- #659
@sjproctor sjproctor mentioned this issue Jul 30, 2024
Merged
1 task
sjproctor added a commit that referenced this issue Jul 31, 2024
@sjproctor
🎁 change clover iiif about > homepage label
f12c70b 
This commit updates the About section text label from `"Homepage"` to
`"Link to item"`. Since this label comes from the clover iiif
JavaScript, it was necessary to create a custom function that finds the
label and overrides it.

There was also a bug that opened the entire page inside the iframe
window. The custom iiif clover override function also added a target
parent to the link to prevent this issue.

Ref:
- #659
@sjproctor sjproctor moved this from In Development to Code Review in utk-hyku Jul 31, 2024
@sjproctor sjproctor moved this from Code Review to Deploy to Staging in utk-hyku Jul 31, 2024
@jillpe jillpe moved this from Deploy to Staging to SoftServ QA in utk-hyku Aug 22, 2024
@sjproctor sjproctor moved this from SoftServ QA to In Development in utk-hyku Aug 27, 2024
@sjproctor sjproctor moved this from In Development to Ready for Development in utk-hyku Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjproctor sjproctor

Labels
good first issue Good for newcomers Pre-Launch
Projects
utk-hyku
Status: Ready for Development
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orangewolf @sjproctor @jillpe