🎁 change clover iiif about > homepage label #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the About section text label from `"Homepage"` to `"Link to item"`. Since this label comes from the clover iiif JavaScript, it was necessary to create a custom function that finds the label and overrides it. There was also a bug that opened the entire page inside the iframe window. The custom iiif clover override function also added a target parent to the link to prevent this issue. Ref: - #659
sjproctor
force-pushed
the
i659-relabel-homepage-link
branch
from
edd1582
to
f12c70b
Compare
laritakr
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Video "About" section contains "homepage" – link to self
This commit updates the About section text label from
"Homepage"to"Link to item". Since this label comes from the clover iiifJavaScript, it was necessary to create a custom function that finds the
label and overrides it.
There was also a bug that opened the entire page inside the iframe
window. The custom iiif clover override function also added a target
parent to the link to prevent this issue.
Ref:
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Link update
Nested webpage bug fix
Screen.Recording.2024-07-30.at.3.20.39.PM.mov