Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I43 alt text tag followup #505

Merged
merged 2 commits into from
Jul 27, 2023
Merged

I43 alt text tag followup #505

merged 2 commits into from
Jul 27, 2023

Conversation

kirkkwang
Copy link
Contributor

@kirkkwang kirkkwang commented Jul 27, 2023

Story

This PR will address the issues found during QA

Ref:

Expected Behavior Before Changes

See comments

Expected Behavior After Changes

  • alt_text has been changed to alt for the logo
  • Collection and Work thumbnails have correct alt text

Screenshots / Video

Dashboard logo image
Work with default thumbnail and alt text Pasted image 20230727091111
Work with custom thumbnail and alt text image
Collection with default thumbnail and alt text image
Collection with custom thumbnail and alt text image

ShanaLMoore and others added 2 commits July 26, 2023 13:37
This commit will fix the alt text for the collection thumbnail on the
dashboard and the Allinson Flex update will fix the thumbnail for the
work on the dashboard.

Ref:
  - samvera-labs/allinson_flex#121
  - #471
@kirkkwang kirkkwang marked this pull request as ready for review July 27, 2023 20:05
@kirkkwang kirkkwang merged commit 728f9c7 into main Jul 27, 2023
7 checks passed
@kirkkwang kirkkwang deleted the i43-alt-text-tag-followup branch July 27, 2023 20:33
@ShanaLMoore ShanaLMoore mentioned this pull request Aug 4, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants