Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly marks field as nullable #1955

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Properly marks field as nullable #1955

merged 1 commit into from
Mar 15, 2024

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck mkeckmkeck commented Mar 15, 2024 •
edited
Loading

Description

Before scireum/sirius-db#647 the framework did not enforce this on Elasticentities. Now we must annotate the fields properly.

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@mkeckmkeck mkeckmkeck added the 🐛 Bugfix Contains only a small fix for an existing bug label Mar 15, 2024
@mkeckmkeck mkeckmkeck merged commit 79f3367 into develop Mar 15, 2024
4 checks passed
@mkeckmkeck mkeckmkeck deleted the SIRI-939_kba_nullable branch March 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scireum-mbo scireum-mbo scireum-mbo approved these changes

@idlira idlira idlira approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkeckmkeck @sabieber @jakobvogel @fhaScireum @idlira @scireum-mbo