Fixes StringProperty not detecting changes to empty string properly #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sirius.db.mixing.properties.StringProperty#setValueToField and sirius.db.mixing.properties.StringProperty#transformValue transform "" be persisted as null - this transformation must be considered when checking for null as well Fixes: SIRI-939
- we do want to persists as null - with previous commit, we properly checked for changes by evaluating empty string as null in comparison of changes as well - now we need to still enable entities to have an empty string as default value, thus the default value mechanism must not map those to null Fixes: SIRI-939
- drive by Fixes: SIRI-939
idlira
approved these changes
Mar 6, 2024
sabieber
approved these changes
Mar 6, 2024
bkositza
approved these changes
Mar 6, 2024
fhaScireum
approved these changes
Mar 6, 2024
mkeckmkeck
added
the
💣 BREAKING CHANGE
mkeckmkeck
added a commit
to scireum/sirius-biz
that referenced
this pull request
Mar 15, 2024
- see scireum/sirius-db#647 Fixes: SIRI-939
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: SIRI-939
BREAKING NOTE:
This fix changes the behavior of handling null values with Elasticsearch.
Previously, on String fields of Elasticsearch entities the NullAllowed annotation was not required as some checks did not run properly.
Now, these checks are running and it is required to annotate nullable String fields on Elasticsearch entities properly using sirius.db.mixing.annotations.NullAllowed
For JDBC and MongoDB this breakage does not apply.