Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the CSS for token-autocomplete in Wondergem and Tycho #1434

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Adjust the CSS for token-autocomplete in Wondergem and Tycho #1434

merged 2 commits into from
Jun 19, 2024

Conversation

jmuscireum
Copy link
Contributor

@jmuscireum jmuscireum commented Jun 18, 2024 •
edited
Loading

Breaking

See scireum/token-autocomplete/pull/81

Description

Optional single select in Wondergem:
Bildschirmfoto 2024-06-18 um 16 27 42

Optional single select in Tycho:
Bildschirmfoto 2024-06-18 um 16 28 30

Multiselect in Tycho:
Bildschirmfoto 2024-06-18 um 16 42 56

Search field with enabled clear button (and additional CSS):
Bildschirmfoto 2024-06-18 um 16 38 23

I also tested the Wondergem Multiselect, but don't have a screenshot anymore. It needed some missing adjustments from previous token-autocomplete changes.

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@jmuscireum jmuscireum added 🧬 Enhancement Contains new features 🕔 Wait for sirius Needs new version from another sirius lib to work labels Jun 18, 2024
@jmuscireum jmuscireum mentioned this pull request Jun 18, 2024
Merged
2 tasks
@jmuscireum jmuscireum added 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code and removed 🕔 Wait for sirius Needs new version from another sirius lib to work labels Jun 19, 2024
@sabieber sabieber merged commit 2b863f8 into develop Jun 19, 2024
5 checks passed
@sabieber sabieber deleted the feature/jmu/token-autocomplete-adjustments branch June 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scireum-mbo scireum-mbo scireum-mbo approved these changes

@mko-sci mko-sci mko-sci approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@idlira idlira idlira approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jmuscireum @sabieber @fhaScireum @idlira @ymo-sci @mkeckmkeck @mko-sci @scireum-mbo