Introduce a clear everything button in multiselect and search autocompletes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line-height only has an effect, if there is actually any text.
We already had some (incorrect) CSS rules, but these weren't used until now.
This adapts the CSS to use the new cross symbol in single selects. This is breaking, as the new CSS class name (token-autocomplete-delete-button) has to be used in overriding CSS rules and in custom token renderers.
... in multiselect and search autocompletes. This button can be used to clear all tokens and user input.
jmuscireum
added
💣 BREAKING CHANGE
3 tasks
fhaScireum
approved these changes
Jun 18, 2024
# Conflicts: # dist/token-autocomplete.js.map
sabieber
approved these changes
Jun 18, 2024
ymo-sci
reviewed
Jun 18, 2024
ymo-sci
approved these changes
Jun 18, 2024
mko-sci
approved these changes
Jun 18, 2024
mkeckmkeck
approved these changes
Jun 19, 2024
idlira
approved these changes
Jun 19, 2024
And give select-arrow-active a more generic name.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
This is breaking, as the new CSS class name (
token-autocomplete-delete-button) has to be used in overriding CSS rules and in custom token renderers.Replace
token-autocomplete-token-deletewithtoken-autocomplete-delete-button.CSS rules might have to be adjusted.
Description
This fixes some small issues (see the first two commits) and introduces a clear button in multiselect and search autocompletes to clear all tokens and user input (remaining commits)
Correct height for empty readonly selects:
Turn the arrow up when the suggestions are displayed:
New symbol for optional single selects:
Multiselect with clear button:
Additional Notes
Checklist