SE-13618: Extend the checks of the TemplateCompiler to include missing required attributes #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: SE-13618
Fixes: SE-13618
Fixes: SE-13618
sabieber
approved these changes
Oct 1, 2024
idlira
reviewed
Oct 1, 2024
Fixes: SE-13618
…thod in the TemplateCompiler. "new HashSet(...)" is needed because "Set.of(...)" is immutable. Fixes: SE-13618
scireum-mbo
approved these changes
Oct 1, 2024
idlira
approved these changes
Oct 1, 2024
… in the else path and not outside. Fixes: SE-13618
idlira
approved these changes
Oct 1, 2024
sabieber
approved these changes
Oct 1, 2024
mkeckmkeck
reviewed
Oct 2, 2024
src/main/java/sirius/pasta/tagliatelle/compiler/TemplateCompiler.java
Outdated
Show resolved
Hide resolved
Fixes: SE-13618
Fixes: SE-13618
fhaScireum
approved these changes
Oct 2, 2024
mkeckmkeck
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TemplateCompiler currently ignores if there are missing attributes that are required because of a missing default value. This circumstance ist only detected during the rendering of the page.
The changes to the TemplateCompiler is now checking for these missing attributes as an early warning to the programmer. Especialy if the templates are overwritten by an artefact.
Additional Notes
Checklist