SE-13618: Extend the checks of the TemplateCompiler to include missing required attributes

src/main/java/sirius/pasta/tagliatelle/tags/ArgTag.java

@@ -18,7 +18,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Arrays;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:arg</tt> which specifies a template argument.
@@ -157,4 +159,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME, PARAM_TYPE));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/BlockTag.java

@@ -18,8 +18,10 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
+import java.util.Set;
 
 /**
  * Handles <tt>i:block</tt> which specifies a template section passed into a tag invocation.
@@ -85,4 +87,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/DefineTag.java

@@ -16,7 +16,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:define</tt> which defines a string as the evaluation result of its body.
@@ -81,4 +83,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/DynamicInvokeTag.java

@@ -16,7 +16,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:dynamicInvoke</tt> which invokes or inlines a given template.
@@ -69,4 +71,9 @@ public Class<?> getExpectedAttributeType(String name) {
         // Accept anything, we don't know yet what to expect at runtime....
         return Callable.class;
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(ATTR_TEMPLATE));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/ExtensionsTag.java

@@ -18,8 +18,11 @@
 import sirius.pasta.tagliatelle.emitter.CompositeEmitter;
 
 import javax.annotation.Nonnull;
+import java.util.Arrays;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:extensions</tt> which invokes all extensions with the given name.
@@ -86,4 +89,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return Callable.class;
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(ATTR_TARGET));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/ExtraBlockTag.java

@@ -17,7 +17,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Permits to add an extra block to the global render context.
@@ -86,4 +88,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/ForTag.java

@@ -18,7 +18,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Arrays;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:for</tt> which emits its body for each item in an {@link Iterable}.
@@ -116,4 +118,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_ITEMS, PARAM_TYPE, PARAM_VAR));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/IfTag.java

@@ -15,7 +15,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:if</tt> which emits its body if a condition is met.
@@ -71,4 +73,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of("test"));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/IncludeTag.java

@@ -17,7 +17,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:include</tt> which includes the contents of the given resource without any processing.
@@ -74,4 +76,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(ATTR_NAME));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/InvokeTag.java

@@ -18,7 +18,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:invoke</tt> which invokes or inlines a given template.
@@ -116,6 +118,21 @@ public Class<?> getExpectedAttributeType(String name) {
         }
     }
 
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        Set<String> result = new HashSet<>();
+        result.add(ATTR_TEMPLATE);
+
+        if (ensureThatTemplateIsPresent()) {
+            for (TemplateArgument arg : template.getArguments()) {
+                if (arg.getDefaultValue() == null) {
+                    result.add(arg.getName());
+                }
+            }
+        }
+        return result;
+    }
+
     private boolean ensureThatTemplateIsPresent() {
         if (template == null) {
             if (templateResolved) {

src/main/java/sirius/pasta/tagliatelle/tags/LocalTag.java

@@ -17,7 +17,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Arrays;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:local</tt> which defines a local variable.
@@ -92,4 +94,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME, PARAM_VALUE));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/PragmaTag.java

@@ -15,7 +15,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Arrays;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:pragma</tt> which defines a pragma (key / value pair) for a template.
@@ -79,4 +81,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/RenderTag.java

@@ -16,7 +16,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:render</tt> which emits the block with the given name.
@@ -79,4 +81,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(PARAM_NAME));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/SassTag.java

@@ -23,7 +23,9 @@
 import java.io.Reader;
 import java.io.StringReader;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:sass</tt> which renders a SASS file into the current template as compiled CSS.
@@ -93,4 +95,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of(SOURCE_ATTRIBUTE));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/SwitchTag.java

@@ -15,7 +15,9 @@
 
 import javax.annotation.Nonnull;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 
 /**
  * Handles <tt>i:switch</tt> which can hold multiple blocks which are only rendered if their name matches an expression.
@@ -68,4 +70,9 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        return new HashSet<>(List.of("test"));
+    }
 }

src/main/java/sirius/pasta/tagliatelle/tags/TaglibTagHandler.java

@@ -13,6 +13,9 @@
 import sirius.pasta.tagliatelle.TemplateArgument;
 import sirius.pasta.tagliatelle.emitter.CompositeEmitter;
 
+import java.util.HashSet;
+import java.util.Set;
+
 /**
  * Handles the invocation of a user-defined tag.
  * <p>
@@ -50,4 +53,15 @@ public Class<?> getExpectedAttributeType(String name) {
 
         return super.getExpectedAttributeType(name);
     }
+
+    @Override
+    public Set<String> getRequiredAttributeNames() {
+        Set<String> result = new HashSet<>();
+        for (TemplateArgument arg : template.getArguments()) {
+            if (arg.getDefaultValue() == null) {
+                result.add(arg.getName());
+            }
+        }
+        return result;
+    }
 }