Remove subscribable value from hash #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvckle
approved these changes
Feb 27, 2024
francocarbonaro
approved these changes
Feb 27, 2024
rayray
reviewed
Nov 5, 2024
| // The hash does not include `currentValue` because for Subscribable | ||
| // values they will likely change during the lifecycle of an object | ||
| // and the hash value is not maintained constant. This can lead to unexpected | ||
| // behavior where a stable hash value is expected. e.g using the object as |
There was a problem hiding this comment.
I'm confused by this change. Wouldn't currentValue changing the hash be expected behavior if a user is including the subscribable in a particular hash for an object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for doing this is pretty much in the comment I added