Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscribable value from hash #48

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove subscribable value from hash #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/Fisticuffs/Subscribable+Hashable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ extension Subscribable: Equatable where Value: Hashable {

extension Subscribable: Hashable where Value: Hashable {
public func hash(into hasher: inout Hasher) {
hasher.combine(currentValue)
// The hash does not include `currentValue` because for Subscribable
// values they will likely change during the lifecycle of an object
// and the hash value is not maintained constant. This can lead to unexpected
// behavior where a stable hash value is expected. e.g using the object as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this change. Wouldn't currentValue changing the hash be expected behavior if a user is including the subscribable in a particular hash for an object?

// a key for a dictionary.
}
}
Loading