Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.6 support in setup.py #364

Closed
wants to merge 6 commits into from
Closed

Conversation

lucywang000
Copy link

hi, I'm trying to learn about frontera and I hope this can be my a starting point of small contribution.

Currently in setup.py only python 3.5 is claim to be supported, I think we can add 3.6 too.

There are a few tests errors in travis ci, and I don't intent to fix them here - maybe for another pr - imo as long as there are same number of fails for python 3.5 and 3.6 then we're good.

Errors for py35 (build log https://travis-ci.com/lucywang000/frontera/jobs/180100043)
errors-py35

Errors for py36(build log https://travis-ci.com/lucywang000/frontera/jobs/180100044)
errors-py36

For 3.7 there is a problem: thriftpy can't install under 3.7, and that project is no longer maintained:

 thriftpy/transport/cybase.c:3192:11: error: ‘PyThreadState {aka struct _ts}’ has no member named ‘exc_traceback’
       tstate->exc_traceback = tb;
             ^
  error: command 'gcc' failed with exit status 1
  
  ----------------------------------------
  Failed building wheel for thriftpy

but there is a new fork called thriftpy2 (see Yelp/py_zipkin#115). This may also be the work of a separate pr.

@sibiryakov
Copy link
Member

Hi @lucywang000 it looks good, but I think we should fix the test before merging this, there could be issues connected with Python3.6 but we're unable to find them unless tests are fixed.

@suzil
Copy link
Contributor

suzil commented Oct 25, 2019

This PR can be closed as there is now 3.6 + 3.7 support from #379.

@sibiryakov sibiryakov closed this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants