Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, I'm trying to learn about frontera and I hope this can be my a starting point of small contribution.
Currently in setup.py only python 3.5 is claim to be supported, I think we can add 3.6 too.
There are a few tests errors in travis ci, and I don't intent to fix them here - maybe for another pr - imo as long as there are same number of fails for python 3.5 and 3.6 then we're good.
Errors for py35 (build log https://travis-ci.com/lucywang000/frontera/jobs/180100043)
Errors for py36(build log https://travis-ci.com/lucywang000/frontera/jobs/180100044)
For 3.7 there is a problem: thriftpy can't install under 3.7, and that project is no longer maintained:
but there is a new fork called thriftpy2 (see Yelp/py_zipkin#115). This may also be the work of a separate pr.