Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Python 3.6 + 3.7 #379

Merged
merged 7 commits into from
Oct 25, 2019
Merged

Bump to Python 3.6 + 3.7 #379

merged 7 commits into from
Oct 25, 2019

Conversation

suzil
Copy link
Contributor

@suzil suzil commented Oct 23, 2019

  • thriftpy is no longer maintained; thriftpy2 is the active implementation
  • test_zmq_message_bus() sometimes fails, so I made the test flaky so that it will try to rerun the test one time if the first try fails

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@02326d2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #379   +/-   ##
=========================================
  Coverage          ?   60.26%           
=========================================
  Files             ?       78           
  Lines             ?     6145           
  Branches          ?      809           
=========================================
  Hits              ?     3703           
  Misses            ?     2267           
  Partials          ?      175
Impacted Files Coverage Δ
frontera/contrib/backends/hbase/utils.py 68.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02326d2...ebb4d32. Read the comment docs.

@suzil suzil changed the title Bump to Python 3.6 Bump to Python 3.6 + 3.7 Oct 23, 2019
@suzil suzil mentioned this pull request Oct 23, 2019
setup.py Outdated Show resolved Hide resolved
@suzil suzil requested a review from sibiryakov October 25, 2019 09:05
@sibiryakov
Copy link
Member

Hey, thank you for that. I think it also makes sense to add thriftpy2 to hbase section, so the ones who will be using frontera with hbase will get the right package. Have you checked the compatibility of happybase with thriftpy2 ?

@suzil
Copy link
Contributor Author

suzil commented Oct 25, 2019

thriftpy2 is fully compatible with thriftpy according to their docs (and they are in the same organization), so it should be OK. I have included thriftpy2 additionally as a requirement of hbase.

@sibiryakov
Copy link
Member

okay! merging

@sibiryakov sibiryakov merged commit b98accd into scrapinghub:master Oct 25, 2019
@suzil suzil deleted the bump/py36 branch October 25, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants