Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manager to 3.2.6 and require it for v1.12 #1795

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Update manager to 3.2.6 and require it for v1.12 #1795

merged 3 commits into from
Mar 12, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Mar 7, 2024

Description of your changes:
This PR updates manager version i our manifests and CI to from 3.2.5 to 3.2.6 which fixes TLS and other issues. Given the restore procedure was broken with TLS and manager 3.2.5, we set 3.2.6 as the minimal version as well.

Which issue is resolved by this Pull Request:
Resolves #

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 7, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
rzetelskik
rzetelskik approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign zimnx

@rzetelskik rzetelskik mentioned this pull request Mar 7, 2024
Merged
zimnx
zimnx approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Member Author

tnozicka commented Mar 7, 2024

#1694 (comment)
/retest

@rzetelskik rzetelskik mentioned this pull request Mar 7, 2024
Closed
@tnozicka
Copy link
Member Author

tnozicka commented Mar 7, 2024

#1802
/retest

@tnozicka
Copy link
Member Author

tnozicka commented Mar 7, 2024

/test images

@scylladb scylladb deleted a comment from scylla-operator-bot bot Mar 7, 2024
@rzetelskik
Copy link
Member

rzetelskik commented Mar 11, 2024 •
edited
Loading

@tnozicka could you update the release matrix and make it required for v1.11 as well? It's necessary for #1675. The updates will also be backported, right?

@tnozicka
Copy link
Member Author

that might be a problem, I don't think requiring it retrospectively for v1.11 would be good. if it need the new API we might just live with not fixing this in v1.11.

@rzetelskik
Copy link
Member

that might be a problem, I don't think requiring it retrospectively for v1.11 would be good. if it need the new API we might just live with not fixing this in v1.11.

It definitely requires the 3.2.6 client, but with older version of the server the new fields will just be ignored. Let's not bump the required version for 1.11 then.

@tnozicka
Copy link
Member Author

ok, if it's backward compatible we can land it as best effort 👍

@tnozicka
Copy link
Member Author

/test images

@tnozicka
Copy link
Member Author

/retest

@tnozicka
Copy link
Member Author

#1814 landed
/retest

@tnozicka
Copy link
Member Author

/test images

@tnozicka
Copy link
Member Author

/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 8e6efb7 into scylladb:master Mar 12, 2024
13 checks passed
@tnozicka tnozicka deleted the update-manager branch March 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik approved these changes

@zimnx zimnx zimnx approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnozicka @rzetelskik @zimnx