Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump manager client to 3.2.6 #1797

Closed
wants to merge 1 commit into from

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Mar 7, 2024

Description of your changes: This PR updates the manager client dependency version to 3.2.6.

Which issue is resolved by this Pull Request:
Prerequisite for #1798.

/kind feature
/priority important-soon
/hold for #1795

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 7, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rzetelskik
Once this PR has been reviewed and has the lgtm label, please assign zimnx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added area/dependency Issues or PRs related to dependency changes priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
Copy link
Contributor

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel-clusterip aab6d2a link true /test e2e-gke-parallel-clusterip

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Member

tnozicka commented Mar 7, 2024

thx, I guess we can just bump all of them since I needed it too #1801

@rzetelskik
Copy link
Member Author

rzetelskik commented Mar 8, 2024

thx, I guess we can just bump all of them since I needed it too #1801

From my experience the appropriate thing to do on an open PR is to request an update, not send your own.
Also I need this one backported to 1.12, is #1801 going to be? Edit: answered here #1801 (comment)

@rzetelskik rzetelskik closed this Mar 8, 2024
@rzetelskik rzetelskik deleted the manager-client-3.2.6 branch March 8, 2024 11:16
@tnozicka
Copy link
Member

tnozicka commented Mar 8, 2024

From my experience the appropriate thing to do on an open PR is to request an update, not send your own.

I've sent my PR before bumping into this one as I was fixing the CVEs and manager was just one of the deps bumped there without caring about it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants