Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version to 1.22 #1861

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Update Go version to 1.22 #1861

merged 2 commits into from
Mar 28, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes: This PR updates the Go version to 1.22 and accommodates the loopvar fix and ranging over integers introduced in this release.

Which issue is resolved by this Pull Request:
Resolves #1860

/kind feature
/priority important-soon

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 26, 2024
@scylla-operator-bot scylla-operator-bot bot added area/dependency Issues or PRs related to dependency changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2024
tnozicka
tnozicka approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
lgtm, thx for taking the time to go over the loops too

/assign @zimnx

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
zimnx
zimnx approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member Author

#1478 (comment)
/test images
/retest

@tnozicka
Copy link
Member

/hold
you need to bump the CI as well
see https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1861/pull-scylla-operator-master-unit/1772754204822081536#1:build-log.txt%3A1

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@tnozicka
Copy link
Member

xref for images fix scylladb/scylla-operator-images#44

@rzetelskik
Copy link
Member Author

/test unit

@rzetelskik
Copy link
Member Author

/test all

@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@rzetelskik
Copy link
Member Author

/retest-required

@tnozicka
Copy link
Member

/override e2e-gke-release-script-latest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gke-release-script-latest

Only the following failed contexts/checkruns were expected:

  • ci/prow/build
  • ci/prow/docs
  • ci/prow/e2e-gke-parallel
  • ci/prow/e2e-gke-parallel-clusterip
  • ci/prow/e2e-gke-release-script-latest
  • ci/prow/e2e-gke-serial
  • ci/prow/helm-build
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • ci/prow/verify-vendorability
  • pull-scylla-operator-master-build
  • pull-scylla-operator-master-docs
  • pull-scylla-operator-master-e2e-gke-parallel
  • pull-scylla-operator-master-e2e-gke-parallel-clusterip
  • pull-scylla-operator-master-e2e-gke-release-script-latest
  • pull-scylla-operator-master-e2e-gke-serial
  • pull-scylla-operator-master-helm-build
  • pull-scylla-operator-master-images
  • pull-scylla-operator-master-unit
  • pull-scylla-operator-master-verify
  • pull-scylla-operator-master-verify-deps
  • pull-scylla-operator-master-verify-vendorability
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-gke-release-script-latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Member

/override ci/prow/e2e-gke-release-script-latest
(shouldn't have been triggered here)

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to this:

/override ci/prow/e2e-gke-release-script-latest
(shouldn't have been triggered here)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot merged commit f08b3f0 into scylladb:master Mar 28, 2024
13 checks passed
@rzetelskik rzetelskik deleted the go-1.22 branch March 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to golang 1.22
3 participants
@rzetelskik @tnozicka @zimnx