Update Go version to 1.22

.github/workflows/releases.yaml

@@ -18,7 +18,7 @@ on:
         required: true
 
 env:
-  go_version: '1.21'
+  go_version: '1.22'
 
 defaults:
   run:

Dockerfile

@@ -1,4 +1,4 @@
-FROM quay.io/scylladb/scylla-operator-images:golang-1.21 AS builder
+FROM quay.io/scylladb/scylla-operator-images:golang-1.22 AS builder
 WORKDIR /go/src/github.com/scylladb/scylla-operator
 COPY . .
 RUN make build --warn-undefined-variables

Makefile

@@ -8,7 +8,7 @@ IMAGE_TAG ?= latest
 IMAGE_REF ?= docker.io/scylladb/scylla-operator:$(IMAGE_TAG)
 
 MAKE_REQUIRED_MIN_VERSION:=4.2 # for SHELLSTATUS
-GO_REQUIRED_MIN_VERSION ?=1.21
+GO_REQUIRED_MIN_VERSION ?=1.22
 
 GIT_TAG ?=$(shell git describe --long --tags --abbrev=7 --match 'v[0-9]*')$(if $(filter $(.SHELLSTATUS),0),,$(error git describe failed))
 GIT_TAG_SHORT ?=$(shell git describe --tags --abbrev=7 --match 'v[0-9]*')$(if $(filter $(.SHELLSTATUS),0),,$(error git describe failed))

go.mod

@@ -1,6 +1,6 @@
 module github.com/scylladb/scylla-operator
 
-go 1.21.8
+go 1.22.1
 
 require (
 	cloud.google.com/go/compute/metadata v0.2.3

pkg/api/scylla/validation/cluster_validation_test.go

@@ -437,9 +437,7 @@ func TestValidateScyllaCluster(t *testing.T) {
 		},
 	}
 
-	for i := range tests {
-		test := tests[i]
-
+	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/api/scylla/validation/nodeconfig_validation_test.go

@@ -121,8 +121,7 @@ func TestValidateNodeConfig(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -269,8 +268,7 @@ func TestValidateNodeConfigUpdate(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/assets/template.go

@@ -47,7 +47,7 @@ func IndentNext(spaceCount int, s string) string {
 func Repeat(s string, count int) string {
 	var sb strings.Builder
 	sb.Grow(len(s) * count)
-	for i := 0; i < count; i++ {
+	for range count {
 		sb.WriteString(s)
 	}
 	return sb.String()

pkg/auth/auth_test.go

@@ -46,9 +46,7 @@ func TestParseBearerAuth(t *testing.T) {
 		},
 	}
 
-	for i := range table {
-		test := table[i]
-
+	for _, test := range table {
 		t.Run(test.Name, func(t *testing.T) {
 			t.Parallel()
 

pkg/cmd/generateapireference/run_test.go

@@ -123,7 +123,6 @@ func TestIndexNestedProps(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/cmd/operator/gather_test.go

@@ -135,7 +135,6 @@ metadata:
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/cmd/operator/mustgather_test.go

@@ -321,7 +321,6 @@ status: {}
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/cmd/operator/webhooks_test.go

@@ -76,8 +76,7 @@ func TestWebhookOptionsRun(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.Name, func(t *testing.T) {
 			t.Parallel()
 

pkg/cmd/releasenotes/helpers_test.go

@@ -36,8 +36,7 @@ func TestParsePullRequestNumber(t *testing.T) {
 		},
 	}
 
-	for i := range ts {
-		test := ts[i]
+	for _, test := range ts {
 		t.Run(test.Name, func(t *testing.T) {
 			t.Parallel()
 

pkg/cmd/releasenotes/render_test.go

@@ -33,8 +33,7 @@ func TestCleanupPRTitle(t *testing.T) {
 		},
 	}
 
-	for i := range ts {
-		test := ts[i]
+	for _, test := range ts {
 		t.Run(test.Name, func(t *testing.T) {
 			t.Parallel()
 

pkg/controller/manager/controller.go

@@ -181,7 +181,7 @@ func (c *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/controller/manager/sync_test.go

@@ -420,8 +420,7 @@ func TestManagerSynchronization(t *testing.T) {
 		},
 	}
 
-	for i := range tcs {
-		test := tcs[i]
+	for _, test := range tcs {
 		t.Run(test.Name, func(t *testing.T) {
 			ctx := context.Background()
 			cluster := &scyllav1.ScyllaCluster{
@@ -496,8 +495,7 @@ func TestBackupTaskChanged(t *testing.T) {
 		},
 	}
 
-	for i := range ts {
-		test := ts[i]
+	for _, test := range ts {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -536,8 +534,7 @@ func TestRepairTaskChanged(t *testing.T) {
 		},
 	}
 
-	for i := range ts {
-		test := ts[i]
+	for _, test := range ts {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/controller/manager/types_old_test.go

@@ -125,7 +125,6 @@ func TestRepairTask_ToManager(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -209,7 +208,6 @@ func TestRepairTask_FromManager(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -303,7 +301,6 @@ func TestBackupTask_ToManager(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -395,7 +392,6 @@ func TestBackupTask_FromManager(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/controller/nodeconfig/controller.go

@@ -370,7 +370,7 @@ func (ncc *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/controller/nodeconfigpod/controller.go

@@ -318,7 +318,7 @@ func (ncpc *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/controller/nodetune/tune_test.go

@@ -43,8 +43,7 @@ func TestStripContainerID(t *testing.T) {
 		},
 	}
 
-	for i := range ts {
-		test := ts[i]
+	for _, test := range ts {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -185,8 +184,7 @@ func TestGetIRQCPUs(t *testing.T) {
 			expectedCpuSet: "0-5",
 		},
 	}
-	for i := range ts {
-		test := ts[i]
+	for _, test := range ts {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/controller/orphanedpv/controller.go

@@ -177,7 +177,7 @@ func (opc *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		opc.wg.Add(1)
 		go func() {
 			defer opc.wg.Done()

pkg/controller/scyllacluster/controller.go

@@ -290,7 +290,7 @@ func (scc *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/controller/scyllacluster/resource_test.go

@@ -1475,7 +1475,6 @@ func TestStatefulSetForRack(t *testing.T) {
 	}
 
 	for _, tc := range tt {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -2008,8 +2007,7 @@ func TestMakeIngresses(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -2648,8 +2646,7 @@ func TestMakeJobs(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/controller/scylladbmonitoring/controller.go

@@ -543,7 +543,7 @@ func (smc *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

pkg/controller/scyllaoperatorconfig/controller.go

@@ -177,7 +177,7 @@ func (opc *Controller) Run(ctx context.Context, workers int) {
 		return
 	}
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		opc.wg.Add(1)
 		go func() {
 			defer opc.wg.Done()

pkg/controllerhelpers/apps_test.go

@@ -260,8 +260,7 @@ func TestIsStatefulSetRolledOut(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			got, gotErr := IsStatefulSetRolledOut(tc.sts)

pkg/controllerhelpers/scylla_test.go

@@ -306,8 +306,7 @@ func TestFindNodeConfigCondition(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -391,8 +390,7 @@ func TestGetScyllaHost(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -567,8 +565,7 @@ func TestGetScyllaNodeBroadcastAddress(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -756,8 +753,7 @@ func TestGetRequiredScyllaHosts(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/crypto/certcreators_test.go

@@ -76,8 +76,6 @@ func TestX509CertCreator_MakeCertificate(t *testing.T) {
 		},
 	}
 	for _, tc := range tt {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/disks/block_test.go

@@ -78,8 +78,7 @@ func TestGetBlockSize(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

pkg/disks/fs_test.go

@@ -83,8 +83,7 @@ func TestMakeFS(t *testing.T) {
 		},
 	}
 
-	for i := range tt {
-		tc := tt[i]
+	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()