Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop GinkgoRecover from ginkgo's container nodes #2100

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Drop GinkgoRecover from ginkgo's container nodes #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/e2e/set/nodeconfig/nodeconfig_disksetup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import (
)

var _ = g.Describe("Node Setup", framework.Serial, func() {
defer g.GinkgoRecover()
f := framework.NewFramework("nodesetup")

ncTemplate := scyllafixture.NodeConfig.ReadOrFail()
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/nodeconfig/nodeconfig_optimizations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ const (
// These tests modify global resource affecting global cluster state.
// They must not be run asynchronously with other tests.
var _ = g.Describe("NodeConfig Optimizations", framework.Serial, func() {
defer g.GinkgoRecover()

f := framework.NewFramework("nodeconfig")

ncTemplate := scyllafixture.NodeConfig.ReadOrFail()
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_alternator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ func (movie Movie) GetKey() map[string]types.AttributeValue {
}

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should set up Alternator API when enabled", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import (
)

var _ = g.Describe("ScyllaCluster authentication", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("agent requires authentication", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_cleanup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("nodes are cleaned up after horizontal scaling", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_evictions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ import (
)

var _ = g.Describe("ScyllaCluster evictions", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should allow one disruption", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_expose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should connect to cluster via Ingresses", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_external_seeds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ import (
)

var _ = g.Describe("MultiDC cluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should form when external seeds are provided to ScyllaClusters", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_hostid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ import (
)

var _ = g.Describe("ScyllaCluster HostID", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should be reflected as a Service annotation", func() {
Expand Down
1 change: 0 additions & 1 deletion test/e2e/set/scyllacluster/scyllacluster_rebootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_replace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

const (
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_sa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should claim preexisting member ServiceAccount and RoleBinding", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_scaling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should support scaling", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_shardawareness.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should allow to build connection pool using shard aware ports", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_sysctl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import (
)

var _ = g.Describe("ScyllaCluster sysctl", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should set container sysctl", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_tls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ import (
)

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should setup and maintain up to date TLS certificates", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_updates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ func addQuantity(lhs resource.Quantity, rhs resource.Quantity) *resource.Quantit
}

var _ = g.Describe("ScyllaCluster", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should rolling restart cluster when forceRedeploymentReason is changed", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_upgrades.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import (
)

var _ = g.Describe("ScyllaCluster upgrades", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

type entry struct {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllacluster_webhooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import (
)

var _ = g.Describe("ScyllaCluster webhook", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should forbid invalid requests", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllamanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ import (
)

var _ = g.Describe("Scylla Manager integration", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

g.It("should register cluster and sync repair tasks", func() {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scyllacluster/scyllamanager_object_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ import (
)

var _ = g.Describe("Scylla Manager integration", framework.RequiresObjectStorage, func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scyllacluster")

type entry struct {
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/set/scylladbmonitoring/scylladbmonitoring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ import (
)

var _ = g.Describe("ScyllaDBMonitoring", func() {
defer g.GinkgoRecover()

f := framework.NewFramework("scylladbmonitoring")

g.It("should setup monitoring stack", func() {
Expand Down