Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework feature tracing experiments and time-stats table, add feature sampling experiment #748

Merged
merged 26 commits into from
Mar 10, 2023

Conversation

jonas-kaufmann
Copy link
Contributor

Requires https://github.com/se-sic/VaRA/pull/972 and https://github.com/se-sic/vara-llvm-project/pull/84.

Even though this contains a lot of changes, the commit history is clean meaning each commit touches different files. I recommend reviewing based on that.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch coverage: 48.67% and project coverage change: -0.13 ⚠️

Comparison is base (a9a3304) 67.09% compared to head (82891d3) 66.96%.

❗ Current head 82891d3 differs from pull request most recent head 4b764c6. Consider uploading reports for the commit 4b764c6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           vara-dev     #748      +/-   ##
============================================
- Coverage     67.09%   66.96%   -0.13%     
============================================
  Files           319      322       +3     
  Lines         24025    24225     +200     
============================================
+ Hits          16119    16222     +103     
- Misses         7906     8003      +97     
Impacted Files Coverage Δ
varats-core/varats/experiment/experiment_util.py 64.58% <ø> (ø)
...ats/varats/experiments/vara/feature_perf_runner.py 44.44% <0.00%> (ø)
...arats/experiments/vara/instrumentation_verifier.py 48.00% <0.00%> (+1.84%) ⬆️
.../projects/perf_tests/feature_perf_cs_collection.py 58.13% <ø> (ø)
varats/varats/tools/bb_config.py 100.00% <ø> (ø)
varats/varats/tables/time_stats_table.py 43.24% <6.25%> (-0.88%) ⬇️
...rats/varats/experiments/vara/feature_experiment.py 40.71% <39.39%> (-0.52%) ⬇️
...ts/varats/experiments/vara/feature_perf_tracing.py 44.13% <44.13%> (ø)
varats/varats/tables/time_workloads.py 40.54% <50.00%> (ø)
...s/varats/experiments/vara/feature_perf_sampling.py 51.42% <51.42%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks quite good, I only found a few nits we should clean up before merging.

varats-core/varats/experiment/experiment_util.py Outdated Show resolved Hide resolved
varats/varats/ts_utils/click_param_types.py Outdated Show resolved Hide resolved
varats/varats/experiments/vara/feature_experiment.py Outdated Show resolved Hide resolved
varats/varats/projects/c_projects/gzip.py Outdated Show resolved Hide resolved
varats/varats/experiments/vara/feature_tracing_stats.py Outdated Show resolved Hide resolved
varats/varats/projects/c_projects/bzip2.py Outdated Show resolved Hide resolved
varats/varats/projects/c_projects/bzip2.py Outdated Show resolved Hide resolved
varats/varats/projects/c_projects/bzip2.py Outdated Show resolved Hide resolved
@vulder vulder requested a review from boehmseb March 9, 2023 08:34
@vulder vulder merged commit ddd7192 into se-sic:vara-dev Mar 10, 2023
@jonas-kaufmann jonas-kaufmann deleted the j-feature_perf_experiments branch March 10, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants