-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework feature tracing experiments and time-stats table, add feature sampling experiment #748
rework feature tracing experiments and time-stats table, add feature sampling experiment #748
Conversation
- reduce boilerplate code - improve names and documentation - introduce enum FeatureInstrType - add a method for tracing to get common actions and set common options - refactor to use benchbuild workloads
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #748 +/- ##
============================================
- Coverage 67.09% 66.96% -0.13%
============================================
Files 319 322 +3
Lines 24025 24225 +200
============================================
+ Hits 16119 16222 +103
- Misses 7906 8003 +97
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks quite good, I only found a few nits we should clean up before merging.
…oad multiple workload files
1ed5ee7
to
317b6ba
Compare
Requires https://github.com/se-sic/VaRA/pull/972 and https://github.com/se-sic/vara-llvm-project/pull/84.
Even though this contains a lot of changes, the commit history is clean meaning each commit touches different files. I recommend reviewing based on that.