Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wasm requests cancel when the future drops. #1755

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Feb 22, 2023

This makes the wasm backend match the behavior of the native one.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@seanmonstar seanmonstar enabled auto-merge (squash) February 22, 2023 20:05
@seanmonstar seanmonstar merged commit bb8fec4 into seanmonstar:master Feb 22, 2023
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Mar 21, 2023
Bumps reqwest from 0.11.14 to 0.11.15.

Release notes
Sourced from reqwest's releases.

v0.11.15
What's Changed

Add RequestBuilder methods to split and reconstruct from its parts.
Add experimental HTTP/3 support. 🧪3️🎉
Fix connection_verbose to log write_vectored calls.
(wasm) Make requests actually cancel if the future is dropped.

New Contributors

@​jneem made their first contribution in seanmonstar/reqwest#1755
@​TurnOfACard made their first contribution in seanmonstar/reqwest#1762
@​j7nw4r made their first contribution in seanmonstar/reqwest#1765

Full Changelog: seanmonstar/reqwest@v0.11.14...v0.11.15



Changelog
Sourced from reqwest's changelog.

v0.11.15

Add RequestBuilder methods to split and reconstruct from its parts.
Add experimental HTTP/3 support.
Fix connection_verbose to log write_vectored calls.
(wasm) Make requests actually cancel if the future is dropped.




Commits

56190bd v0.11.15
df2b3ba wasm: fix premature abort for streaming bodies (#1782)
4db868b Make HTTP/3 feature more unstable (#1780)
57a8a01 Add Experimental HTTP/3 Support (#1599)
119366e async/request: add methods to split and reassemble a RequestBuilder (#1770)
673449a docs: fix wording on main docs page (#1765)
c2ac875 Clarify the documentation to show that get will fail if the total download ti...
bb8fec4 Make wasm requests cancel when the future drops. (#1755)
bdd4db0 Fix connection_verbose to log write_vectored calls (#1737)
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants