Clarify that blocking::get may fail if exceeding timeout #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nload time is exceeded
seanmonstar
approved these changes
Mar 1, 2023
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Mar 21, 2023
Bumps reqwest from 0.11.14 to 0.11.15. Release notes Sourced from reqwest's releases. v0.11.15 What's Changed Add RequestBuilder methods to split and reconstruct from its parts. Add experimental HTTP/3 support. 🧪3️🎉 Fix connection_verbose to log write_vectored calls. (wasm) Make requests actually cancel if the future is dropped. New Contributors @jneem made their first contribution in seanmonstar/reqwest#1755 @TurnOfACard made their first contribution in seanmonstar/reqwest#1762 @j7nw4r made their first contribution in seanmonstar/reqwest#1765 Full Changelog: seanmonstar/reqwest@v0.11.14...v0.11.15 Changelog Sourced from reqwest's changelog. v0.11.15 Add RequestBuilder methods to split and reconstruct from its parts. Add experimental HTTP/3 support. Fix connection_verbose to log write_vectored calls. (wasm) Make requests actually cancel if the future is dropped. Commits 56190bd v0.11.15 df2b3ba wasm: fix premature abort for streaming bodies (#1782) 4db868b Make HTTP/3 feature more unstable (#1780) 57a8a01 Add Experimental HTTP/3 Support (#1599) 119366e async/request: add methods to split and reassemble a RequestBuilder (#1770) 673449a docs: fix wording on main docs page (#1765) c2ac875 Clarify the documentation to show that get will fail if the total download ti... bb8fec4 Make wasm requests cancel when the future drops. (#1755) bdd4db0 Fix connection_verbose to log write_vectored calls (#1737) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
…nload time is exceeded (seanmonstar#1762) Co-authored-by: Ryan <ryan@ryanj.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor change to clarify that a
blocking::getrequest may fail if the total download time is exceeded.This aligns the function call with the
blocking::client::ClientBuilder::timeoutdocumentation.